From: Bello Olamide <belkid98@gmail.com>
Date: Tue, 06 Jan 2026 13:44:56 GMT
Subject: Re: [Outreachy PATCH v2] environment: move "core.attributesFile" into repo-setting
Message-ID: <CAD=f0L9H5Q=zW02nr11OSBNgFH3UMLwVjVjn3zhgZ2rjwE85WA@mail.gmail.com>
In-Reply-To: <CAD=f0L9BEPSQivgpM7qURT+WFDY-+Ys_M6Knv8hE0JDw4Wjj5A@mail.gmail.com>

On Tue, 6 Jan 2026 at 10:33, Bello Olamide <belkid98@gmail.com> wrote:
>
> On Mon, 5 Jan 2026 at 23:28, Junio C Hamano <gitster@pobox.com> wrote:
> >
> > Phillip Wood <phillip.wood123@gmail.com> writes:
> >
> > > On 05/01/2026 14:23, Phillip Wood wrote:
> > >>
> > >> It is quite common that moving from parsing config settings eagerly by
> > >> calling repo_config() at startup to parsing them lazily via 'stuct
> > >> repo_settings' causes regressions like this. We really should find a way
> > >> to address that before moving more settings into 'struct repo_settings'
> > >
> > > See
> > > https://lore.kernel.org/git/d61c966b-61ae-4ba9-b983-c8dab6e2c292@gmail.com
> > > for some discussion about a possible solution.
> >
> > Nice, but I suspect it would be an improvement already without
> > passing repository instance via git_default_config() and instead
> > have the code use the_repository; it is even possible not to have
> > any repository when the callchain executes.

But won't this be a temporary solution since the goal is to prevent the use of
`the_repository`?