From: Bello Olamide <belkid98@gmail.com>
Date: Thu, 22 Jan 2026 15:11:26 GMT
Subject: Re: [Outreachy PATCH v3 1/3] environment: stop storing `core.attributesFile` globally
Message-ID: <CAD=f0L9BAjFeURkngMM6kzK+6_8TmLHy9zvFKXcz3ZYPvDG=_g@mail.gmail.com>
In-Reply-To: <60dfb907-c2b8-4fd4-b975-742f7ec18721@gmail.com>

On Thu, 22 Jan 2026 at 15:40, Phillip Wood <phillip.wood123@gmail.com> wrote:
>
> Hi Olamide

Hello Phillip

>
> On 17/01/2026 20:59, Olamide Caleb Bello wrote:
> > The config value is parsed in git_default_core_config(), loaded eagerly
> > and stored in the global variable `git_attributes_file`.
> > Storing this value in a global variable can lead to unexpected
> > behaviours when more than one Git repository run in the same Git process.
>
> It would maybe be helpful to explain what the unexpected behavior is and
> how it is caused.

Okay thank you.

>
> > diff --git a/environment.h b/environment.h
> > index 51898c99cd..aea73ff25b 100644
> > --- a/environment.h
> > +++ b/environment.h
> > @@ -84,6 +84,12 @@ extern const char * const local_repo_env[];
> >
> >   struct strvec;
> >
> > +/* Config values parsed by git_default_config() */
> > +struct repo_config_values {
> > +     /* core config values */
> > +     char *attributes_file_path;
>
> The variable we're converting is called "attributes_file", do we really
> need to add a "_path" suffix?

Okay I will remove it

>
> Apart from that everything here looks good
>
> Thanks
>
> Phillip

Thank you