From: Bello Olamide Date: Tue, 14 Apr 2026 14:26:12 GMT Subject: Re: [PATCH v2 0/8] repo_config_values: migrate more globals Message-ID: In-Reply-To: On Tue, 14 Apr 2026 at 10:10, Karthik Nayak wrote: > > Olamide Caleb Bello writes: > > > Overview > > ======== > > This series continues the effort to migrate repository-specific global > > variables into struct repo_config_values, further reducing global > > state and improving repository isolation. > > > > The previous series introduced the infrastructure for storing > > repository-dependent configuration in repo_config_values. This series > > extends that work by moving additional environment-related globals into > > that struct and updating their call sites accordingly. > > > > This helps avoid cross-repository interference when multiple > > repositories are used within the same process, and continues preparing > > Git for improved library usage and better encapsulation of repository > > state. > > > > Changes since v1: > > - Dropped "Base series" section as the dependency has been merged. > > - Fixed handling of pack_compression_level: removed use of a local copy and > > updated code to operate directly on cfg->pack_compression_level to avoid > > inconsistencies with option parsing. > > > > I had a look at the series, the changes look good. I do think this is a > nice opportunity to set some of the variables to be of type bool as > needed. Apart from that, I'd like to see some more comments about each > of the variables and improved commit messages talking about why this > change is done this way. > > Thanks, > Karthik Hi Karthik, Thanks for taking a look. I’ll review the series and update variables to use bools where appropriate. I’ll also improve the commit messages to explain better why each variable is moved into `repo_config_values`, and add comments describing their purpose and why they are safe to scope per-repository. I’ll send a v3 with these updates. Thanks, Olamide