From: Bello Olamide <belkid98@gmail.com>
Date: Thu, 23 Oct 2025 08:14:20 GMT
Subject: Re: [Outreachy PATCH v5 1/2] gpg-interface: do not use misdesigned strbuf_split*()
Message-ID: <CAD=f0L-pmB22DpK7kDr7Oe4iztPeHgbserTqn3=icYVvryVx9w@mail.gmail.com>
In-Reply-To: <CAP8UFD2GCG5y7c=utQ43M=TfVPSDF0qUUAXH+U2nRpeuKfcW=w@mail.gmail.com>

On Wed, 22 Oct 2025 at 14:56, Christian Couder
<christian.couder@gmail.com> wrote:
>
> On Wed, Oct 22, 2025 at 2:40 PM Olamide Caleb Bello <belkid98@gmail.com> wrote:
> >
> > In get_ssh_finger_print(), the output of the `ssh-keygen` command is
> > put into `fingerprint_stdout` strbuf.
> > The string in `fingerprint_stdout` is then split into up to 3 strbufs
>
> Nit: it's not clear if the first sentence of this commit message is
> part of the same paragraph as the second sentence or not. If you
> reroll this patch, I would suggest making it clearly part of the same
> paragraph like this:
>
> "In get_ssh_finger_print(), the output of the `ssh-keygen` command is
> put into `fingerprint_stdout` strbuf. The string in `fingerprint_stdout` is
> then split into up to 3 strbufs using strbuf_split_max(). However..."
>
> Otherwise this patch looks fine to me.
>
> Thanks.

Okay thank you very much

Bello