From: Bello Olamide <belkid98@gmail.com>
Date: Mon, 20 Oct 2025 18:50:57 GMT
Subject: Re: [Outreachy PATCH v3 1/2] gpg-interface: replace strbuf_split*() with string_list_split*()
Message-ID: <CAD=f0L-Q2pFDr5RWjEfUwn1SOKU-PVgRebhVKbQ-FFmQR8540w@mail.gmail.com>
In-Reply-To: <1cdc170b-569d-4874-b1d8-dd645c0545b0@app.fastmail.com>

On Mon, 20 Oct 2025 at 19:37, Kristoffer Haugsbakk
<kristofferhaugsbakk@fastmail.com> wrote:
>
>
> On Mon, Oct 20, 2025, at 20:25, Bello Olamide wrote:
> > On Mon, 20 Oct 2025 at 17:46, Kristoffer Haugsbakk
> > <kristofferhaugsbakk@fastmail.com> wrote:
> >> Signoff should go at the end of the commit message.  You’re saying that
> >> you are signing off on the changes as well as what was written in the
> >> commit message before that line.  If I later add mine:
> >>
> >>     Signed-off-by: Olamide Caleb Bello <belkid98@gmail.com>
> >>     Signed-off-by: ME
> >>
> >> I would be saying that I am signing off on the changes as well as the
> >> previous lines in the commit message, including that line that you
> >> wrote.
> >
> > Please just to make sure I get you correctly, you are saying the Signoff
> > should be the last thing in the commit message.
> >
> > Like I should put it below the other tags so that if you also want to add yours,
> > It can easily go below mine and it would mean you are signing off on the
> > changes including my own Signoff?
> >
> >>
> >> > Reported-by: Junio Hamano <gitster@pobox.com>
> >> > Helped-by: Christian Couder <christian.couder@gmail.com>
> >> > Helped-by: Junio Hamano <gitster@pobox.com>
> >        It should go below here instead?
>
> Yes, that is my understanding. :)

Okay noted.
Thank you very much Kristoffer