From: Lucian Poston <lucian.poston@gmail.com>
Date: Wed, 18 Apr 2012 02:23:49 GMT
Subject: Re: [PATCH v3 4/7] t4052: Adjust --graph --stat output for prefixes
Message-ID: <CACz_eyfvC9OWwBscCTHVvs+udRW5_QUReZnxpPVWSrL1MAC6rA@mail.gmail.com>
In-Reply-To: <7vzkabtsw9.fsf@alter.siamese.dyndns.org>

On Mon, Apr 16, 2012 at 11:48, Junio C Hamano <gitster@pobox.com> wrote:
>> @@ -117,7 +117,7 @@ cat >expect40 <<'EOF'
>>   abcd | 1000 ++++++++++++++++++++++++++
>>  EOF
>>  cat >expect40-graph <<'EOF'
>> -|  abcd | 1000 ++++++++++++++++++++++++++
>> +|  abcd | 1000 ++++++++++++++++++++++++
>>  EOF
>>  while read verb expect cmd args
>>  do
>> @@ -127,12 +127,6 @@ do
>>               test_cmp "$expect" actual
>>       '
>>
>> -     test_expect_success "$cmd $verb statGraphWidth config" '
>> -             git -c diff.statGraphWidth=26 $cmd $args >output
>> -             grep " | " output >actual &&
>> -             test_cmp "$expect" actual
>> -     '
>> -
>
> This is unclear.  Why does this need to be removed?

This test was actually only moved. There were 4 test_expect_success in
a while loop -- 2 tested COLUMNS=40, and 2 tested
diff.statGraphWidth=26. I moved the two tests for diff.statGraphWidth
to a new while loop. expect40-graph varies between these two sets of
tests, so I thought it cleaner to separate them so that the
expectation could be defined separately.