From: Lucian Poston <lucian.poston@gmail.com>
Date: Wed, 18 Apr 2012 02:31:24 GMT
Subject: Re: [PATCH v3 5/7] t4052: Add tests to illustrate issues with restrictive COLUMNS
Message-ID: <CACz_eydRcYNs1TOpRjM91tzmBrXjs4sKzBrFFvXGk0hEQ9zEMw@mail.gmail.com>
In-Reply-To: <7v7gxfv7h5.fsf@alter.siamese.dyndns.org>

On Mon, Apr 16, 2012 at 11:48, Junio C Hamano <gitster@pobox.com> wrote:
> Lucian Poston <lucian.poston@gmail.com> writes:
>
>> Signed-off-by: Lucian Poston <lucian.poston@gmail.com>
>> ---
>
> Sorry, the patch text itself does not tell me what it wants to "illustate"
> at all.
>
> I _guess_ that you are saying that the output for expect1 and
> expect1-graph should be limited to very narrow width, not like the
> humongous output like we see in the added test vector, and it will be
> fixed with your patch 6/7.
>
> If that is the case, please structure this part of the series like this:
>
>        5/7: add test vector to illustrate what the correct output should
>             be, but mark the test with "test_expect_failure".
>
>        6/7: update the code to fix it, and flip the "test_expect_failure"
>             in 5/7 to "test_expect_success".
>
> And 7/7 will become unneeded.

Done. Thanks.