From: Lucian Poston <lucian.poston@gmail.com>
Date: Wed, 18 Apr 2012 21:19:09 GMT
Subject: Re: [PATCH v4 3/4] t4052: Test diff-stat output with minimum columns
Message-ID: <CACz_eydRKq6d5LU3OpYhZ84_TXOXoxYS=_PzkEJOfDinB1D2Kg@mail.gmail.com>
In-Reply-To: <7v4nsglru2.fsf@alter.siamese.dyndns.org>

On Wed, Apr 18, 2012 at 13:15, Junio C Hamano <gitster@pobox.com> wrote:
> Lucian Poston <lucian.poston@gmail.com> writes:
>
>> When COLUMNS or --stat-width restricts the diff-stat width to near the
>> minimum, 26 columns, the graph_width value becomes negative. Consequently, the
>> graph part of diff-stat is not resized properly.
>>
>> Signed-off-by: Lucian Poston <lucian.poston@gmail.com>
>> ---
>>  t/t4052-stat-output.sh |   28 ++++++++++++++++++++++++++++
>>  1 files changed, 28 insertions(+), 0 deletions(-)
>
> Running t4052 with this patch applied reports
>
> # fixed 2 known breakage(s)
> # still have 5 known breakage(s)
> # passed all remaining 81 test(s)
>
> Please mark the ones that already pass as "test_expect_success", leaving
> the only broken ones as "test_expect_failure".  Otherwise the patch to the
> test that contains the fix would not illustrate what it fixed.

Sorry about that. Fixed in the recently emailed diffs.

Thanks!