From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date: Thu, 08 Dec 2011 11:06:27 GMT
Subject: Re: [PATCH] index-pack: eliminate unlimited recursion in get_delta_base()
Message-ID: <CACsJy8Dr14ek-Fv4a4eAo_QRHyHrg=2X=YaMRy1z8UXRdcescg@mail.gmail.com>
In-Reply-To: <CAJo=hJvrk3Jzg3dQhQnfbmKAFovLuEtJAP4rakHPFeuZ0T5R7g@mail.gmail.com>

2011/12/8 Shawn Pearce <spearce@spearce.org>:
> I think you missed the critical recursion. The real work is the
> recursion within find_unresolved_deltas(). This little helper
> get_base_data() shouldn't be tripping over these cases unless we have
> run out of delta_base_cache_limit and released objects near the base
> end of the delta chain, in which case this will restore them.
>
> Maybe this is useful on its own, but in my opinion its not an
> interesting patch to consider without first fixing
> find_unresolved_deltas's recursion.

Thanks. I missed that function. Will try to fix it.
-- 
Duy