From: Nguyen Thai Ngoc Duy Date: Wed, 01 Feb 2012 14:49:50 GMT Subject: Re: [PATCH] pack-objects: convert to use parse_options() Message-ID: In-Reply-To: On Wed, Feb 1, 2012 at 9:30 PM, Nguyen Thai Ngoc Duy wrote: >        /* Traditionally "pack-objects [options] base extra" failed; >         * we would however want to take refs parameter that would >         * have been given to upstream rev-list ourselves, which means >         * we somehow want to say what the base name is.  So the >         * syntax would be: >         * >         * pack-objects [options] base >         * >         * in other words, we would treat the first non-option as the >         * base_name and send everything else to the internal revision >         * walker. >         */ > > The last paragraph does not hold true anymore as far as I understand > the code. IOW it drops everything in argv after base name. Looking > back in history, the change was made by 8d1d8f8 (pack-objects: further > work on internal rev-list logic. - 2006-09-06). Nothing is mentioned > why it drops the remaining of argv. I suspect this is a regression and > we should reinstate the behavior as the comment says. Nope, false alarm. The comment was introduced in b5d97e6 (pack-objects: run rev-list equivalent internally. - 2006-09-04) and the remaining of argv has been ignored ever since. -- Duy