From: Duy Nguyen <pclouds@gmail.com>
Date: Mon, 24 Apr 2017 13:13:55 GMT
Subject: Re: [PATCH 1/5] add SWAP macro
Message-ID: <CACsJy8DoK__R5k0+5EVoagc+NiFNd1yjxWxwOS234H-wJ047wg@mail.gmail.com>
In-Reply-To: <20170424114919.kvgiybj2cm7xecpp@sigill.intra.peff.net>

On Mon, Apr 24, 2017 at 6:49 PM, Jeff King <peff@peff.net> wrote:
> diff --git a/prio-queue.c b/prio-queue.c
> index 17252d231..fc3860fdc 100644
> --- a/prio-queue.c
> +++ b/prio-queue.c
> @@ -21,7 +21,7 @@ void prio_queue_reverse(struct prio_queue *queue)
>
>         if (queue->compare != NULL)
>                 die("BUG: prio_queue_reverse() on non-LIFO queue");
> -       for (i = 0; i <= (j = (queue->nr - 1) - i); i++)
> +       for (i = 0; i < (j = (queue->nr - 1) - i); i++)
>                 swap(queue, i, j);
>  }

FWIW This shuts valgrind-3.10.1 up.
-- 
Duy