From: Duy Nguyen Date: Fri, 13 Dec 2013 00:58:46 GMT Subject: Re: [PATCH] send-pack.c: mark a file-local function static Message-ID: In-Reply-To: <52AA43AA.9030703@ramsay1.demon.co.uk> On Fri, Dec 13, 2013 at 6:15 AM, Ramsay Jones wrote: > BTW, I have not been following these patches, but I noticed that the > 'remove_nonexistent_ours_in_pack()' function has no callers. (There are > two commented out callers - but they seem to have *always* been commented > out ;-) ). So, step 5 is no longer required? :-D It's more of an optimization than a requirement, to avoid expensive calculation later. Uncommenting is possible but I need to pass the pack file name around a bit. -- Duy