From: Duy Nguyen Date: Sat, 10 Feb 2018 10:23:45 GMT Subject: Re: [PATCH v3 22/35] upload-pack: support shallow requests Message-ID: In-Reply-To: On Thu, Feb 8, 2018 at 2:00 AM, Stefan Beller wrote: >> + >> + deepen-relative >> + Requests that the semantics of the "deepen" command be changed >> + to indicate that the depth requested is relative to the clients >> + current shallow boundary, instead of relative to the remote >> + refs. >> + >> + deepen-since >> + Requests that the shallow clone/fetch should be cut at a >> + specific time, instead of depth. Internally it's equivalent of >> + doing "rev-list --max-age=". Cannot be used with >> + "deepen". >> + >> + deepen-not >> + Requests that the shallow clone/fetch should be cut at a >> + specific revision specified by '', instead of a depth. >> + Internally it's equivalent of doing "rev-list --not ". >> + Cannot be used with "deepen", but can be used with >> + "deepen-since". > > What happens if those are given in combination? It should be described in the old protocol document or I did a bad job documenting it. Some of these can be combined (I think it's AND logic from rev-list point of view), with the exception of --depth which does not use rev-list underneath and cannot be combined with the others. -- Duy