From: Duy Nguyen <pclouds@gmail.com>
Date: Sun, 22 Jul 2018 09:23:23 GMT
Subject: Re: [PATCH v6 3/8] block alloc: add lifecycle APIs for cache_entry structs
Message-ID: <CACsJy8DfK=QaNsYRNBH8r0JJERAK0ppn4v6jZK03T22VfZA9Aw@mail.gmail.com>
In-Reply-To: <20180702193745.8940-4-jamill@microsoft.com>

On Mon, Jul 2, 2018 at 9:49 PM Jameson Miller <jamill@microsoft.com> wrote:
> +struct cache_entry *make_transient_cache_entry(unsigned int mode, const struct object_id *oid,
> +                                              const char *path, int stage)
> +{
> +       struct cache_entry *ce;
> +       int len;
> +
> +       if (!verify_path(path, mode)) {
> +               error("Invalid path '%s'", path);

Please wrap all new user-visible strings in _().

> +               return NULL;
> +       }
-- 
Duy