From: Duy Nguyen <pclouds@gmail.com>
Date: Thu, 30 Jan 2014 05:36:58 GMT
Subject: Re: [PATCH v2 3/3] diff: turn skip_stat_unmatch on selectively
Message-ID: <CACsJy8Dd+baRUi0YjnqDXFi-Fv=K9NxwO=YbYuVEfQkdEXWWWQ@mail.gmail.com>
In-Reply-To: <xmqq61p2k2u5.fsf@gitster.dls.corp.google.com>

On Thu, Jan 30, 2014 at 2:25 AM, Junio C Hamano <gitster@pobox.com> wrote:
>> On Tue, Jan 28, 2014 at 02:51:45PM -0800, Junio C Hamano wrote:
> This however shows that the existing test *KNEW* that it was enough
> to check just a few cases (especially, there is no reason to make
> sure that blob vs file-in-working-tree case behaves sanely), because
> the auto-refresh would kick in for all codepaths.  Now you are
> making that assumption invalid, shouldn't the patch also split the
> tests to cover individual cases?

Drop the last patch, then. It's a "while at there" cleanup patch. If
it's non trivial then it could be taken up later when somebody's
interested. I have a few topics ongoing and not sure I'll go through
diff.c to identify and write tests for all cases.
-- 
Duy