From: Duy Nguyen Date: Sat, 02 Jun 2018 04:41:06 GMT Subject: Re: [PATCH v4] json_writer: new routines to create data in JSON format Message-ID: In-Reply-To: <20180326143136.47116-2-git@jeffhostetler.com> On Mon, Mar 26, 2018 at 4:31 PM, wrote: > +static inline void assert_in_array(const struct json_writer *jw) > +{ > + if (!jw->open_stack.len) > + die("json-writer: array: missing jw_array_begin()"); When you reroll, please consider marking all these string for translation with _(), unless these are for machine consumption. > + if (jw->open_stack.buf[jw->open_stack.len - 1] != '[') > + die("json-writer: array: not in array"); -- Duy