From: Duy Nguyen Date: Thu, 31 Oct 2013 12:03:03 GMT Subject: Re: [PATCH v2 11/19] pack-objects: use bitmaps when packing objects Message-ID: In-Reply-To: <20131030200754.GB23011@sigill.intra.peff.net> On Thu, Oct 31, 2013 at 3:07 AM, Jeff King wrote: > I think there are two cases that we need to consider: > > 1. We have a full repo and somebody requests a shallow clone for us. > We probably do not want to use bitmaps here. In the series we have > been testing, shallow clones turned off bitmaps because we do not > use the internal rev_list. But as of cdab485 (upload-pack: delegate > rev walking in shallow fetch to pack-objects), that distinction > doesn't hold. I think we can check the use of --shallow-file > instead of explicitly turning off bitmaps there. There's an (non-existing yet) case 1': somebody requests a clone and the source clone is already shallow. is_repository_shallow() could catch both cases. > 2. We have a shallow clone that wants to repack. We probably want to > turn off bitmap writing here. I don't think that grafts actually > matter here, because pack-objects should always be looking at the > true graph. It would mean that using "git rev-list > --use-bitmap-index" does not respect the grafts, and we should > probably disable it in that case (and ditto for replacements). Right. I forgot that the repo must be complete before it's grafted. -- Duy