From: Duy Nguyen Date: Wed, 15 Oct 2014 14:14:10 GMT Subject: Re: [PATCH 0/4] Multiple worktrees vs. submodules fixes Message-ID: In-Reply-To: <20141014221509.GA10580@wheezy.local> On Wed, Oct 15, 2014 at 5:15 AM, Max Kirillov wrote: >> Hmm, so I tend towards adding GIT_COMMON_DIR to >> local_repo_env until we figured out how to handle this. >> Without that I fear bad things will happen, at least for a >> superproject with multiple checkout-to work trees where >> the same submodule is initialized more than once ... > > I learned about local_repo_env and agree it should include > GIT_COMMON_DIR. Unless it is removed at all... It's in the same class as GIT_DIR and GIT_WORK_TREE so yeah it should be in local_repo_env. Removing it would break t0060-path-utils.sh at least. Unless we have a very good reason to remove it, I think we should keep it as is. -- Duy