From: Nguyen Thai Ngoc Duy Date: Sun, 30 Sep 2012 03:45:30 GMT Subject: Re: [PATCH 2/3] revision: add --grep-reflog to filter commits by reflog messages Message-ID: In-Reply-To: <7vbogoiqzs.fsf@alter.siamese.dyndns.org> On Sun, Sep 30, 2012 at 2:11 AM, Junio C Hamano wrote: > How about squashing this in? I've future-proofed commit_match() a > bit while at it; it would be cleaner to add new fake headers if the > function is done this way. Sure. It looks good to me. > --- a/Documentation/rev-list-options.txt > +++ b/Documentation/rev-list-options.txt > @@ -56,8 +56,8 @@ endif::git-rev-list[] > Limit the commits output to ones with reflog entries that > match the specified pattern (regular expression). With > more than one `--grep-reflog`, commits whose reflog message > - matches any of the given patterns are chosen. Ignored unless > - `--walk-reflogs` is given. > + matches any of the given patterns are chosen. It is an > + error to use this option unless `--walk-reflogs` is in use. We could even drop the part about --walk-reflogs. Users will soon figure it out when they try it. -- Duy