From: Duy Nguyen Date: Fri, 19 Oct 2018 16:56:50 GMT Subject: Re: [PATCH v2 19/24] submodule.c: remove implicit dependency on the_index Message-ID: In-Reply-To: <20181019164237.GA24740@sigill.intra.peff.net> On Fri, Oct 19, 2018 at 6:42 PM Jeff King wrote: > > > I don't see anything in the "Kill the_index, final part" series that > > > would need it. > > > > Yeah. Killing the_index is just the first small step (didn't look that > > small when I started). Now it's all about the_repository ;-) and we > > have like 400 references of it just in library code. > > I suspect it is much worse than that, even. There are many spots that > likely are relying on global data that _should_ be in the repository > struct but aren't yet. I don't think there's even an easy way to count > those. ;) One step at a time. I'm already in the process of killing some global vars related to setup code and was feeling very risky. Don't scare me away with all other potential global data! -- Duy