From: Duy Nguyen Date: Mon, 10 Jun 2013 01:25:25 GMT Subject: Re: [PATCH v2 00/15] Towards a more awesome git branch Message-ID: In-Reply-To: <1370800474-8940-1-git-send-email-artagnon@gmail.com> On Mon, Jun 10, 2013 at 12:54 AM, Ramkumar Ramachandra wrote: > Hi, > > This iteration contains some minor fixups (courtesy reviews by Eric > Sunshine and Junio), and some tests from Duy squashed in. I'm starting to think this is a half-baked solution. It hides problems, for example commit placeholders should produce empty string, not the literal placeholders. Doing that from a callback is really ugly. There's also the problem with sorting and quoting (both only work with for-each-ref atoms only). A better solution may be improving pretty.c to the point where it can more or less replace f-e-r's --format. Even more, I think pretty engine should be easily added to cat-file (especially --batch), as a generic way to extract information. But for the reason I will send shortly, I will not work not work on this series or any others. -- Duy