From: Duy Nguyen Date: Sat, 18 Aug 2018 16:05:17 GMT Subject: Re: [PATCH v2 2/2] repack: repack promisor objects if -a or -A is set Message-ID: In-Reply-To: <3dab08e467c23f2c0785e34c3a8703d809b6479a.1533767314.git.jonathantanmy@google.com> On Thu, Aug 9, 2018 at 12:35 AM Jonathan Tan wrote: > @@ -179,6 +179,76 @@ static void prepare_pack_objects(struct child_process *cmd, > cmd->out = -1; > } > > +/* > + * Write oid to the given struct child_process's stdin, starting it first if > + * necessary. > + */ > +static int write_oid(const struct object_id *oid, struct packed_git *pack, > + uint32_t pos, void *data) > +{ > + struct child_process *cmd = data; > + > + if (cmd->in == -1) { > + if (start_command(cmd)) > + die("Could not start pack-objects to repack promisor objects"); _() ? (also other messages) -- Duy