From: Duy Nguyen <pclouds@gmail.com>
Date: Sat, 28 Feb 2015 11:36:23 GMT
Subject: Re: [RFC/PATCH 2/5] upload-pack: support out of band client capability requests
Message-ID: <CACsJy8D1xHh7tQkX=+4H_FvLdk53RmtNwVPNuo9Ng2x9oQFPjw@mail.gmail.com>
In-Reply-To: <1425085318-30537-3-git-send-email-sbeller@google.com>

On Sat, Feb 28, 2015 at 8:01 AM, Stefan Beller <sbeller@google.com> wrote:
> Notes:
>     v1:
>     I am still undecided if the client should then accept/resend
>     the capabilities to confirm them, which would make the client the
>     ultimate decider which capabilities are used.
>
>     My gut feeling is to rather let the server make the final decision
>     for the capabilities, as it will use some requested capabilities
>     already to not send out all the refs.

pack-capabilities.txt says

"Client will then send a space separated list of capabilities it wants
to be in effect. The client MUST NOT ask for capabilities the server
did not say it supports."

What was sent out of band is what the client can support, not what it
wants. So perhaps drop this patch and let the client decide exactly
what it wants.
-- 
Duy