From: Duy Nguyen <pclouds@gmail.com>
Date: Mon, 20 Mar 2017 13:14:20 GMT
Subject: Re: [PATCH 00/20] object_id part 7
Message-ID: <CACsJy8D1ZjO1pQJv2TmoYDyptyvhEfrcK=RMSeJE5VPG9=Jh0A@mail.gmail.com>
In-Reply-To: <20170318211954.564030-1-sandals@crustytoothpaste.net>

On Sun, Mar 19, 2017 at 4:19 AM, brian m. carlson
<sandals@crustytoothpaste.net> wrote:
> This is part 7 in the continuing transition to use struct object_id.

It feels very nice to see many ".hash" and "->hash" go away. Looking
forward to seeing you kill sha1 in sha1_file.c, object.c and friends.
That one (and read-cache) must be a battle.

I'm not familiar with many parts that this series touches so I may
have missed something subtle, but overall it looks good to me. Thank
you for working on this.

> I chose not to rename the sha1-array.[ch] files

You'll have to rename sha1_file.c, sha1_name.c too and might start a
code reorganization revolution by renaming sha1-array.[ch] ;-)
-- 
Duy