From: Duy Nguyen Date: Wed, 12 Mar 2014 23:26:27 GMT Subject: Re: [PATCH] general style: replaces memcmp() with starts_with() Message-ID: In-Reply-To: <532097D0.4070909@web.de> On Thu, Mar 13, 2014 at 12:22 AM, Jens Lehmann wrote: > That spot uses memcmp() because ce->name may > not be 0-terminated. ce->name is 0-terminated (at least if it's created the normal way, I haven't checked where this "ce" in submodule.c comes from). ce_namelen() is just an optimization because we happen to store name's length if it's shorter than 4096, so there's no need to strlen(ce->name) again. -- Duy