From: Duy Nguyen <pclouds@gmail.com>
Date: Fri, 24 Jan 2014 05:48:54 GMT
Subject: Re: [PATCH 2/2] t4010: match_pathspec_depth() and trailing slash after submodule
Message-ID: <CACsJy8Cw3bkOuw8Xbw4hvcNGtZ0w6gqEkFCmfR2mfju3xHvNOA@mail.gmail.com>
In-Reply-To: <xmqqwqhqs7j0.fsf@gitster.dls.corp.google.com>

On Fri, Jan 24, 2014 at 4:38 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Jens Lehmann <Jens.Lehmann@web.de> writes:
>
>> ... But a single
>> trailing '/' does mark "submod" as a directory, which I think is
>> ok for a submodule. And it makes life easier for the user if we
>> accept that, as shell completion will add it there automatically.
>
> OK, that would be annoying.
>
> Perhaps the completion is what is broken here, then?  I dunno, and
> haven't thought things through.

My reasoning is more simple minded: if "git diff HEAD HEAD^ submod/"
works, the user would expect "git diff HEAD submod/" to work too. I
think I've got something working with a bit refactoring. Will send out
soon.
-- 
Duy