From: Duy Nguyen Date: Thu, 30 May 2013 00:04:30 GMT Subject: Re: [PATCH v3] wildmatch: properly fold case everywhere Message-ID: In-Reply-To: On Thu, May 30, 2013 at 12:57 AM, Anthony Ramine wrote: >>> If the range to match against is [A-_], it will become [a-_] which is an empty range, ord('a') > ord('_'). I think it is simpler to reuse toupper() after the fact as I did. >>> >>> Anyway maybe I should add a test for that corner case? >> >> Yeah I was thinking about such a case, but I saw glibc do it... I >> guess we just found another bug, at least in compat/fnmatch.c. Yes a >> test for it would be great, in case I change my mind 2 years from now >> and decide to turn it the other way ;) > > Should I patch compat/fnmatch.c too? That would make it different from the glibc's one. No. I plan to remove compat/fnmatch and always use wildmatch, even ignoring system's fnmatch. That would keep the matching behavior consistent across platforms. -- Duy