From: Duy Nguyen <pclouds@gmail.com>
Date: Wed, 09 Jan 2013 14:59:56 GMT
Subject: Re: On --depth=funny value
Message-ID: <CACsJy8Cp-2gRhdU+V8H7+FeWZXfptJLbzw1swxdks61fO+73NQ@mail.gmail.com>
In-Reply-To: <7vy5g383sy.fsf_-_@alter.siamese.dyndns.org>

On Wed, Jan 9, 2013 at 9:53 AM, Junio C Hamano <gitster@pobox.com> wrote:
>  * Make "git fetch" and "git clone" die() when zero or negative
>    number is given with --depth=$N, for the following reasons:
>    ...

For Stefan when you update the patch. If "git fetch --depth=0" is
considered invalid too as Junio outlined, then the proper place for
the check is transport.c:set_git_option(), not clone.c. It already
catches --depth=random-string. Adding "depth < 1" check should be
trivial. You may want to update builtin/fetch-pack.c too because it
does not share this code.
-- 
Duy