From: Duy Nguyen Date: Mon, 13 Jun 2016 11:31:29 GMT Subject: Re: [PATCH 4/3] use string_list initializer consistently Message-ID: In-Reply-To: <20160613100420.GA16229@sigill.intra.peff.net> On Mon, Jun 13, 2016 at 5:04 PM, Jeff King wrote: > -- >8 -- > Subject: use string_list initializer consistently > > There are two types of string_lists: those that own the > string memory, and those that don't. You can tell the > difference by the strdup_strings flag, and one should use > either STRING_LIST_INIT_DUP, or STRING_LIST_INIT_NODUP as an > initializer. > > Historically, the normal all-zeros initialization has > corresponded to the NODUP case. Many sites use no > initializer at all, and that works as a shorthand for that > case. But for a reader of the code, it can be hard to > remember which is which. Let's be more explicit and actually > have each site declare which type it means to use. > > This is a fairly mechanical conversion; I assumed each site > was correct as-is, and just switched them all to NODUP. Looking good. If we still want to reduce noise level down (by a tiny bit), we could remove _INIT because I think it's obvious from struct string_list var = STRING_LIST_NODUP; that's it's initialization (I wish we could write "auto var = STRING_LIST_NODUP;") -- Duy