From: Duy Nguyen <pclouds@gmail.com>
Date: Fri, 12 Apr 2013 23:36:02 GMT
Subject: Re: [PATCH v2 02/12] pretty: share code between format_decoration and show_decorations
Message-ID: <CACsJy8CmzuDxCPebMaEkmF=u3xA4wXq2ydRMiU_rNsy1Pr411w@mail.gmail.com>
In-Reply-To: <515E83EF.3070609@gmail.com>

On Fri, Apr 5, 2013 at 6:57 PM, Jakub Narębski <jnareb@gmail.com> wrote:
>>> +void format_decoration(struct strbuf *sb,
>>> +                   const struct commit *commit,
>>> +                   int use_color);
>>
>> I think you can fit these on a single line, especially if you drop
>> the unused variable names (they help when there are more than one
>> parameter of the same type to document the order of the arguments,
>> but that does not apply here).  That would help people who run
>> "grep" on the header files without using CTAGS/ETAGS.
>
> Well, I think "int use_color" should be left with variable name,
> don't you think?

I don't care too much about this. If Junio does not respond, I'll
leave the names in place (in one long line).
--
Duy