From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date: Tue, 28 Feb 2012 12:56:30 GMT
Subject: Re: [RFC PATCH 2a] pretty: detect missing \n\n in commit message
Message-ID: <CACsJy8Cj477QnMz5ZD=i7FcFV15__zP9S-kt81pmZ2=opPBi5w@mail.gmail.com>
In-Reply-To: <5234ba4babd28d9430750d227d629b4d4386b131.1330425111.git.trast@student.ethz.ch>

On Tue, Feb 28, 2012 at 5:37 PM, Thomas Rast <trast@student.ethz.ch> wrote:
> get_header()'s exit condition is finding the \n\n that separates the
> commit header from its message.  If such a double newline is not
> present, it segfaults.  Catch this case and die().

I'd prefer a gentler approach: if there's no \n\n, accept that this
commit has no body. I think I encountered such commits in the test
suite when I tried to convert commit encoding partially and made the
assumption that \n\n must exist.
-- 
Duy