From: Duy Nguyen <pclouds@gmail.com>
Date: Fri, 07 Apr 2017 11:32:22 GMT
Subject: Re: [PATCH v2 10/20] ref-cache: introduce a new type, ref_cache
Message-ID: <CACsJy8Careik7fCtXo_Luu40G8YPXAgZomFKDkCOuuOfEYm7nA@mail.gmail.com>
In-Reply-To: <e90f9afd20cbfc07f8844ba4f81e7369b4b9bb00.1490966385.git.mhagger@alum.mit.edu>

On Fri, Mar 31, 2017 at 9:11 PM, Michael Haggerty <mhagger@alum.mit.edu> wrote:
> +void free_ref_cache(struct ref_cache *cache)
> +{
> +       free_ref_entry(cache->root);
> +       free(cache);
> +}

free(NULL) is no-op (and safe). Maybe we should follow the same
pattern for free_ref_cache(). It's really up to you.
-- 
Duy