From: Duy Nguyen <pclouds@gmail.com>
Date: Sat, 25 Jun 2016 16:38:36 GMT
Subject: Re: [PATCH v12 18/20] index-helper: optionally automatically run
Message-ID: <CACsJy8CaN4fkd9tzvR8NeqpVHmKH5p6S151-A+SN0_LtrU3_fw@mail.gmail.com>
In-Reply-To: <1463694357-6503-19-git-send-email-dturner@twopensource.com>

On Thu, May 19, 2016 at 11:45 PM, David Turner <dturner@twopensource.com> wrote:
> +static void autorun_index_helper(void)
> +{
> +       const char *argv[] = {"git-index-helper", "--detach", "--autorun", NULL};
> +       if (want_auto_index_helper() <= 0)
> +               return;
> +
> +       trace_argv_printf(argv, "trace: auto index-helper:");

I'm pretty sure run_command() does call this (with "trace:
run_command:" prefix instead, maybe drop this line?

> +
> +       if (run_command_v_opt(argv,
> +                             RUN_SILENT_EXEC_FAILURE | RUN_CLEAN_ON_EXIT))
> +               warning(_("You specified indexhelper.autorun, but running git-index-helper failed."));
> +}
-- 
Duy