From: Duy Nguyen Date: Sun, 20 Jul 2014 12:45:33 GMT Subject: Re: [PATCH 3/3] use xgetcwd() get the current directory or die Message-ID: In-Reply-To: <53CBA65B.7090504@web.de> On Sun, Jul 20, 2014 at 6:22 PM, René Scharfe wrote: > Convert several calls of getcwd() and die() to use xgetcwd() instead. > This way we get rid of fixed-size buffers (which can be too small > depending on the used file system) and gain consistent error messages. > > Signed-off-by: Rene Scharfe > --- > builtin/init-db.c | 17 ++++++++--------- > builtin/rev-parse.c | 6 +++--- > dir.c | 12 ++++++++---- > trace.c | 7 ++++--- > 4 files changed, 23 insertions(+), 19 deletions(-) There should be a 4/3 to replace the remaining getcwd with strbuf_getcwd. But I guess we could add that to the low hanging fruit list. -- Duy