From: Duy Nguyen <pclouds@gmail.com>
Date: Sun, 15 Mar 2015 23:41:08 GMT
Subject: Re: [PATCH 03/16] list-files: show paths relative to cwd
Message-ID: <CACsJy8CX0WJryLV5C6=0pV=Ssgp3uxpF0pYX5Q1eKHOedAFOzg@mail.gmail.com>
In-Reply-To: <xmqqh9tmt0zt.fsf@gitster.dls.corp.google.com>

On Mon, Mar 16, 2015 at 4:16 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Duy Nguyen <pclouds@gmail.com> writes:
>
>> Exactly. We would need to sort and stuff later on, so true filenames
>> are preserved in util->item. A cleaner way is perhaps carry all
>> metadata in item->util and item->string remains true filename, then do
>> all the formatting, coloring for all strings just before displaying.
>
> I guess we are then in agreement with my review comment on [04/16].

Yes. I'm redoing it. I will probably stop using string-list as well
(it's inherited from the old code), just an array of struct.
-- 
Duy