From: Duy Nguyen Date: Tue, 10 Mar 2015 06:39:58 GMT Subject: Re: [PATCH 07/16] list-files: show directories as well as files Message-ID: In-Reply-To: On Tue, Mar 10, 2015 at 1:23 PM, Eric Sunshine wrote: >> +static int add_directory(struct string_list *result, >> + const char *name) >> +{ >> + struct strbuf sb = STRBUF_INIT; >> + const char *p; >> + >> + strbuf_add(&sb, name, strlen(name)); > > strbuf_addstr() perhaps? Yeah. The previous version of this function takes string length as an argument, but then I dropped that and used strlen() instead. Thanks for catching. -- Duy