From: Duy Nguyen Date: Wed, 20 Mar 2019 01:50:12 GMT Subject: Re: [RFC PATCH 01/11] sequencer: always discard index after checkout Message-ID: In-Reply-To: <20190319190317.6632-2-phillip.wood123@gmail.com> On Wed, Mar 20, 2019 at 2:04 AM Phillip Wood wrote: > It would perhaps be better to pass around the_index rather than > the_repository Not by a large margin. For sequencer.c most operations require more than just the index and passing 'struct repository *' around has been the norm. And as soon as you need to load the index back (not sure if you should do it here btw, after discard_index, since we have the index loaded before) you need 'struct repository' not 'struct index_state'. > builtin/rebase--interactive.c | 2 +- > sequencer.c | 27 +++++++++++++++++---------- > sequencer.h | 3 ++- > 3 files changed, 20 insertions(+), 12 deletions(-) -- Duy