From: Duy Nguyen Date: Thu, 27 Feb 2014 02:43:56 GMT Subject: Re: [PATCH v3 17/25] setup.c: detect $GIT_COMMON_DIR check_repository_format_gently() Message-ID: In-Reply-To: On Thu, Feb 27, 2014 at 7:22 AM, Junio C Hamano wrote: > Nguyễn Thái Ngọc Duy writes: > >> Signed-off-by: Nguyễn Thái Ngọc Duy >> --- > > It is a good thing to do to read config from the real repository we > are borrowing from when we have .git/commondir, but it makes me > wonder if we should signal some kind of error if we find .git/config > in such a borrowing repository---which will be silently ignored. > > My gut feeling is that such a check may be necessary, but may not > belong to this function. Just checking. Once we do this, what about .git/refs/.. that is also ignored in such a repo? I can see the point that config could be manually edited so the user may edit the file at the wrong place, so it's good the we catch this exception. -- Duy