From: Duy Nguyen <pclouds@gmail.com>
Date: Wed, 30 Jan 2013 03:36:10 GMT
Subject: Re: [PATCH 4/6] introduce a commit metapack
Message-ID: <CACsJy8COCpr_CvQPhBFtVnsKztA3xgo01=zKG4WPcFfCbNTmgw@mail.gmail.com>
In-Reply-To: <20130129091610.GD9999@sigill.intra.peff.net>

On Tue, Jan 29, 2013 at 4:16 PM, Jeff King <peff@peff.net> wrote:
> +int commit_metapack(unsigned char *sha1,
> +                   uint32_t *timestamp,
> +                   unsigned char **tree,
> +                   unsigned char **parent1,
> +                   unsigned char **parent2)
> +{

Nit picking. tree, parent1 and parent2 can/should be "const unsigned char **".
-- 
Duy