From: Duy Nguyen <pclouds@gmail.com>
Date: Sat, 21 Jul 2018 06:18:14 GMT
Subject: Re: [PATCH v2 02/23] archive-tar.c: mark more strings for translation
Message-ID: <CACsJy8CMJJ1xW1zfnngGXqhJpwL0_dw9o7rTfq-YRTfqKjt-7A@mail.gmail.com>
In-Reply-To: <xmqqmuunf5ny.fsf@gitster-ct.c.googlers.com>

On Thu, Jul 19, 2018 at 8:21 PM Junio C Hamano <gitster@pobox.com> wrote:
>
> Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:
>
> > @@ -256,7 +256,7 @@ static int write_tar_entry(struct archiver_args *args,
> >               *header.typeflag = TYPEFLAG_REG;
> >               mode = (mode | ((mode & 0100) ? 0777 : 0666)) & ~tar_umask;
> >       } else {
> > -             return error("unsupported file mode: 0%o (SHA1: %s)",
> > +             return error(_("unsupported file mode: 0%o (SHA1: %s)"),
> >                            mode, oid_to_hex(oid));
>
> This is no longer sha1_to_hex(); the "SHA1" in the message should
> probably have been updated when it happened.
>
> Cleaning it up is outside the scope of this patch.

Yeah. I also asked Brian [1] what to use here instead. I think it's
much easier to go through git.pot then fix all at once. Whatever
leftover after that could be fixed as we see them.

[1] https://public-inbox.org/git/20180603182724.GA288937@genre.crustytoothpaste.net/

> #leftoverbits
-- 
Duy