From: Duy Nguyen Date: Sun, 22 Jul 2018 09:20:12 GMT Subject: Re: [PATCH v6 8/8] fetch-pack: implement ref-in-want Message-ID: In-Reply-To: <20180627223023.49659-9-bmwill@google.com> On Thu, Jun 28, 2018 at 12:33 AM Brandon Williams wrote: > +static void receive_wanted_refs(struct packet_reader *reader, struct ref *refs) > +{ > + process_section_header(reader, "wanted-refs", 0); > + while (packet_reader_read(reader) == PACKET_READ_NORMAL) { > + struct object_id oid; > + const char *end; > + struct ref *r = NULL; > + > + if (parse_oid_hex(reader->line, &oid, &end) || *end++ != ' ') > + die("expected wanted-ref, got '%s'", reader->line); Could you do a follow and wrap all these strings in _() since this one is already in 'next'? -- Duy