From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date: Fri, 03 Feb 2012 09:59:59 GMT
Subject: Re: [PATCH] Convert isatty() calls to git_isatty()
Message-ID: <CACsJy8CHwSyWqMOB9LKxK2fqa0gP7TamnesMTR-D2Tny57C=Vg@mail.gmail.com>
In-Reply-To: <4F2BAD8B.1080403@viscovery.net>

2012/2/3 Johannes Sixt <j.sixt@viscovery.net>:
> Am 2/3/2012 9:35, schrieb Nguyễn Thái Ngọc Duy:
>> isatty() is used to check for interactive use cases. However if pager is
>> set up, standard file handles may be redirected and istty() calls later
>> on no longer reflect the original state.
>
> So what? What's wrong with this behavior?
>
> You converted many cases involving progress indicators. Wouldn't the new
> code pipe progress output to the pager where earlier it was not shown if a
> pager was present? That is plainly wrong: Progress output is destined only
> for the terminal, not for the pager.

Yeah right. My mistake.
-- 
Duy