From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date: Sat, 05 Nov 2011 09:02:01 GMT
Subject: Re: [PATCH] fsck: print progress
Message-ID: <CACsJy8CEh6x1O0AHpiErZ_+T2hGwjRZofygmsgVX8_WXV7uDTA@mail.gmail.com>
In-Reply-To: <4EB4EB70.40801@gmail.com>

2011/11/5 Stephen Boyd <bebarino@gmail.com>:
> On 11/03/2011 08:10 PM, Nguyễn Thái Ngọc Duy wrote:
>> diff --git a/Documentation/git-fsck.txt b/Documentation/git-fsck.txt
> [...]
>> +--progress::
>> +--no-progress::
>> +     When fsck is run in a terminal, it will show the progress.
>> +     These options can force progress to be shown or not
>> +     regardless terminal check.
>
> Can we reuse the --progress description in fetch-options.txt (minus the q)?
>
> --[no]-progress::
>        Progress status is reported on the standard error stream
>        by default when it is attached to a terminal. This flag
>        forces progress status even if the standard error stream
>        is not directed to a terminal.
>
>
>> ++
>> +Progress is not shown when --verbose is used. --progress is ignored
>> +in this case.
>
> What progress isn't shown? How about
>
>        If --verbose is used with --progress the progress status
>        will not be shown.

"-q" in fetch-options.txt can be converted to "--no-progress or
--verbose". How about this?

--progress::
--no-progress::
	Progress status is reported on the standard error stream by
	default when it is attached to a terminal, unless
	--no-progress or --verbose is specified. --progress forces
	progress status even if the standard error stream is not
	directed to a terminal.
-- 
Duy