From: Duy Nguyen Date: Mon, 08 Apr 2013 11:04:13 GMT Subject: Re: [PATCH] t3700 (add): add failing test for add with submodules Message-ID: In-Reply-To: <1365416809-4396-1-git-send-email-artagnon@gmail.com> On Mon, Apr 8, 2013 at 8:26 PM, Ramkumar Ramachandra wrote: > +test_expect_failure 'git add should not go past submodule boundaries' ' > + mkdir submodule_dir && > + ( > + cd submodule_dir && > + git init && > + cat >foo <<-\EOF && > + Some content > + EOF > + git add foo && > + git commit -a -m "Add foo" > + ) && > + git add submodule_dir/foo Thanks. I yhink the last line above should be "test_must_fail git add ...". I'm half way of fixing it (I think treat_leading_directory is a bit loose). Will continue tomorrow (or this weekend, depending on $DAYJOB) -- Duy