From: Nguyen Thai Ngoc Duy Date: Fri, 02 Sep 2011 03:55:33 GMT Subject: Re: [PATCH 3/3] fetch: verify we have everything we need before updating our ref Message-ID: In-Reply-To: <1314917015-3587-4-git-send-email-gitster@pobox.com> On Fri, Sep 2, 2011 at 5:43 AM, Junio C Hamano wrote: > The "git fetch" command works in two phases. The remote side tells us what > objects are at the tip of the refs we are fetching from, and transfers the > objects missing from our side. After storing the objects in our repository, > we update our remote tracking branches to point at the updated tips of the > refs. > > A broken or malicious remote side could send a perfectly well-formed pack > data during the object transfer phase, but there is no guarantee that the > given data actually fill the gap between the objects we originally had and > the refs we are updating to. What about receive-pack? Does it have the same breakage? -- Duy