From: Duy Nguyen Date: Tue, 10 Sep 2013 00:52:15 GMT Subject: Re: pack v4 trees with a canonical base Message-ID: In-Reply-To: On Tue, Sep 10, 2013 at 2:25 AM, Nicolas Pitre wrote: > An eventual optimization to index-pack when completing a pack would be > to attempt the encoding of appended tree objects into the packv4 format > using the existing dictionary table in the pack, and fall back to the > canonical format if that table doesn't have all the necessary elements. Yeah, it's on the improvement todo list. The way pack-objects creates dictionaries right now, the tree dict should contain all elements the base trees need so fall back is only necessary when trees are have extra zeros in mode field. -- Duy