From: Duy Nguyen Date: Sun, 10 Mar 2013 12:14:25 GMT Subject: Re: [PATCH v2 3/6] match_basename: use strncmp instead of strcmp Message-ID: In-Reply-To: On Sun, Mar 10, 2013 at 7:11 PM, Antoine Pelisse wrote: >>> By the way, if we know the length of the string, we could use memcmp. >>> This one is allowed to compare 4-bytes at a time (he doesn't care >>> about end of string). This is true because the value of the length >>> parameter is no longer "at most". >> >> We still need to worry about access violation after NUL when two >> strings have different lengths. That could be avoided in this >> particular case, but I think it's too fragile. > > Why would we need to compare if the strings don't have the same length > ? We already do that in combine-diff.c:append_lost(). Watching movie and replying to git@ don't mix. You're right we don't need to compare if lengths are different. What was I thinking.. -- Duy