From: Duy Nguyen Date: Mon, 05 Aug 2013 14:23:38 GMT Subject: About close() in commit_lock_file() Message-ID: close() is added in commit_lock_file(), before rename(), by 4723ee9 (Close files opened by lock_file() before unlinking. - 2007-11-13), which is needed by Windows. But doesn't that create a gap between close() and rename() on other platforms where another process can replace .lock file with something else before rename() is executed? Should we enclose close() in #ifdef __MINGW32__ (and maybe __CYGWIN__)? -- Duy