From: Duy Nguyen <pclouds@gmail.com>
Date: Wed, 01 Mar 2017 12:00:50 GMT
Subject: Re: [PATCH v5 12/24] refs.c: kill register_ref_store(), add register_submodule_ref_store()
Message-ID: <CACsJy8BvKvo8_bRHH++dp53DaPbDVkKU0EUQC7ofYvBo+Tec0Q@mail.gmail.com>
In-Reply-To: <92ff53b6-8a85-9be8-e14f-18eb1fcaf732@alum.mit.edu>

On Wed, Mar 1, 2017 at 1:03 AM, Michael Haggerty <mhagger@alum.mit.edu> wrote:
>>  struct ref_store *get_ref_store(const char *submodule)
>>  {
>>       struct strbuf submodule_sb = STRBUF_INIT;
>> @@ -1480,6 +1479,9 @@ struct ref_store *get_ref_store(const char *submodule)
>>       if (is_nonbare_repository_dir(&submodule_sb))
>>               refs = ref_store_init(submodule);
>>       strbuf_release(&submodule_sb);
>> +
>> +     if (refs)
>
> I think `refs` should always be non-NULL here for the same reason.

That's true if is_nonbar_repo... returns true. If it's false (e.g.
uninitialized submodule) then refs remains NULL from before (I didn't
know about this until I hit a segfault in rev-list in another series)
-- 
Duy