From: Duy Nguyen <pclouds@gmail.com>
Date: Tue, 28 May 2013 12:53:47 GMT
Subject: Re: [PATCH] wildmatch: properly fold case everywhere
Message-ID: <CACsJy8Bu2XvapGHjcKZJuATqB90MXSCoNHkke9CBeiwSvzpH8A@mail.gmail.com>
In-Reply-To: <1369744361-44918-1-git-send-email-n.oxyde@gmail.com>

On Tue, May 28, 2013 at 7:32 PM, Anthony Ramine <n.oxyde@gmail.com> wrote:
> @@ -196,6 +196,11 @@ static int dowild(const uchar *p, const uchar *text, unsigned int flags)
>                                         }
>                                         if (t_ch <= p_ch && t_ch >= prev_ch)
>                                                 matched = 1;
> +                                       else if ((flags & WM_CASEFOLD) && ISLOWER(t_ch)) {
> +                                               t_ch = toupper(t_ch);

This happens in a while loop where t_ch may be used again. Should we
make a local copy of toupper(t_ch) and leave t_ch untouched?

> +                                               if (t_ch <= p_ch && t_ch >= prev_ch)
> +                                                       matched = 1;
> +                                       }
>                                         p_ch = 0; /* This makes "prev_ch" get set to 0. */
>                                 } else if (p_ch == '[' && p[1] == ':') {
>                                         const uchar *s;
--
Duy